Compatibility with bmf "mesh" file format #88
Merged
leoguignard merged 13 commits intov3.xfrom Sep 19, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.x #88 +/- ##
=======================================
Coverage 86.43% 86.43%
=======================================
Files 20 20
Lines 1792 1792
=======================================
Hits 1549 1549
Misses 243 243 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leoguignard
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a loader function for the bmf "mesh" file format. This format allows very simple tracks (i.e just chains) to be stored, but cannot handle divisions.
Loading bmf files requires the
binarymeshformatlibrary, and meshes are then stored in the LineageTree instance per-nodes via the dictionarylT.mesh. For instance,lT.mesh[i]contains a dictionary{"vertices":np.array([...]),"faces":np.array([...])}of vertices coordinates (shape(N, d), withdthe number of spatial dimensions) and triangles by nodes indices (shape(N, 3)). We could choose to create a minimal class to hold the meshes data instead, this is debatable.